Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom button for threat details toggle #40298

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Use custom button for threat details toggle #40298

merged 1 commit into from
Nov 22, 2024

Conversation

nateweller
Copy link
Contributor

Proposed changes:

  • Uses custom styles for the "show threat details" button.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#40214

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • N/A

@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Nov 21, 2024
@nateweller nateweller requested a review from dkmyta November 21, 2024 21:48
@nateweller nateweller self-assigned this Nov 21, 2024
@nateweller nateweller mentioned this pull request Nov 21, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/components/threat-details-modal-flow-details-btn branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/components/threat-details-modal-flow-details-btn

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/components/threat-details-modal-flow-details-btn

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/components

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 21, 2024
@dkmyta dkmyta merged commit 220d28c into update/components/threat-details-modal-flow Nov 22, 2024
71 of 72 checks passed
@dkmyta dkmyta deleted the update/components/threat-details-modal-flow-details-btn branch November 22, 2024 16:39
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Nov 22, 2024
dkmyta added a commit that referenced this pull request Nov 25, 2024
@dkmyta @nateweller
ThreatModal: Update flow (#40214)
0f6c6cf 
* Add ThreatDetailsModal component and stories

* changelog

* Fix type error

* Fix child component overflow-x styling

* Update scan package changelog

* Add util for fixerState and separate subcomponents

* Add user connection gate

* Add credentials gate

* Fix stories

* Fix stories

* Fix credentials type

* Update content flow

* Improve organization

* Separation and reorg

* Improve

* Remove redundant code

* Adjust modal content

* Generalize component name

* Updates after renaming

* Ensure close button exists for vulns modal

* changelog

* Updates/fixes

* Add detailed action

* changelog

* Add actionToConfirm flag for rendering conditional content based on action selected

* Update approach to single view

* Move notices to ThreatActions

* Add fixer notices

* Fix styling

* Additional improvements

* Fix gap

* Remove actionToConfirm flag, to be readded in integration

* Early return on ThreatActions for fixed threats

* Make threat status check optional

* Use custom button for threat details toggle (#40298)

* Use Button and override internal styles

* Fix classes

* Move fixerState comp to ThreatFixConfirmation

* Rely heavily on context provider

* Fix styles

---------

Co-authored-by: Nate Weller <nate.weller@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkmyta dkmyta Awaiting requested review from dkmyta

Assignees

@nateweller nateweller

Labels
[JS Package] Components RNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nateweller @dkmyta