Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a docker-based dev env #40934
Adding a docker-based dev env #40934
Changes from all commits
67296ba
4391224
40d5719
5510974
d244c27
6fbd418
5fe1007
f3ba0e7
2c460cd
0db9170
308d456
e098e69
06a24a4
409396b
5e8d778
0dd5ba8
3f5a875
91a0a0d
a8266cf
b68ff2b
71f3eab
c4ca2f0
c20cb23
4a74468
aacf2e6
14bceb1
29be249
c5cde21
2048987
5cb6e82
38ed1b1
0bf7446
155120f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Interesting...
This means it won't be runnable directly from a monorepo checkout. But maybe you could somehow point
npm -g
at the monorepo checkout as a source when testing?And hopefully eslint doesn't get confused by missing imports, although I suppose we could probably just disable the relevant rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nod, with having it in the workspace,
pnpm cli-setup
would pick up on it and globally linkjp
to the copy in that monorepo. Then, when you nerfnode_modules
(or delete that checkout totally) and want to usejp init
to start again, no joy.It might be something we can adjust in another way, but if we keep
jp
to be relatively stable (most everything it does fires code within the monorepo's pnpm install), it might not be horrible to have it be annoying to test changes within the monorepo? Or, you cannpm install
within theprojects/js-packages/jetpack-cli
dir and runnode projects/js-packages/jetpack-cli/bin/jp.js [cmd]
(how I did most of my testing).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't too worried about the potential difficulty in testing. But documenting how to test it in the js-package's README.md might be a good idea.