Carousel: Check if image parent is not a link #6647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
added
[Feature] Carousel
zinigor
requested changes
Mar 14, 2017
modules/carousel/jetpack-carousel.js
Outdated
| @@ -445,6 +445,11 @@ jQuery(document).ready(function($) { | |||
| return; | |||
| } | |||
|
|
|||
| // skip if the parent is not a link | |||
There was a problem hiding this comment.
Looks good, but one tiny nitpick. We're not talking about the parent here, but about the container, right?
There was a problem hiding this comment.
Yes and no 😄 . The container is actually the parent, but I will change this if you want.
zinigor
approved these changes
Mar 14, 2017
|
OK, so I guess the |
zinigor
added
[Status] Ready to Merge
dereksmart
removed
the
[Status] Ready to Merge
dereksmart
pushed a commit
that referenced
this pull request
Mar 14, 2017
* Carousel: Check if the image parent is not a link * Change 'parent' to 'container' in comment
|
merged to 4.7 eae9b8f |
dereksmart
pushed a commit
that referenced
this pull request
Mar 14, 2017
dereksmart
pushed a commit
that referenced
this pull request
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6638
Changes proposed in this Pull Request:
Testing instructions:
atag (you can use the following code )Uncaught TypeError: Cannot read property 'split' of undefinedOn line 451 of
modules/carousel/jetpack-carousel.jscc @jeherve