Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options: add basic options to sync whitelist #9308

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Options: add basic options to sync whitelist #9308

merged 2 commits into from
Apr 13, 2018

Conversation

simison
Copy link
Member

@simison simison commented Apr 13, 2018 •
edited
Loading

Adds a set of basic options to whitelist that are safe to sync:

  • no filters (other than basic get_option() pre/post filters)
  • simple enough content

These would all be used for capturing events for the Activity Log.

Test

Change these settings in your WP admin interface and observe them get synced.

  • 'start_of_week' → In general
  • 'blacklist_keys' → In discussion
  • 'posts_per_page' → In reading
  • 'posts_per_rss' → In reading
  • 'show_on_front' → In reading (radio button)
  • 'ping_sites' → In writing ("Update services")
  • 'uploads_use_yearmonth_folders' → In media
  • 'date_format' → In general
  • 'time_format' → In general

Tests pass:

phpunit --filter=WP_Test_Jetpack_Sync_Options

@simison
Options: add basic options to sync whitelist
3065826 
Adds set of basic options to whitelist that are safe to sync:
- no filters
- simple enough content
@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Package] Sync labels Apr 13, 2018
@simison simison requested a review from a team as a code owner April 13, 2018 11:30
@simison simison requested a review from a team April 13, 2018 13:41
@simison simison merged commit 1776af2 into master Apr 13, 2018
@simison simison deleted the add/sync-options branch April 13, 2018 14:57
@simison simison removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 13, 2018
@oskosk oskosk added this to the 6.1 milestone Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezama lezama lezama approved these changes

Assignees
No one assigned
Labels
[Package] Sync [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@simison @lezama @oskosk @matticbot