Protect: Revert XML RPC request should get hard blocker quicke #9312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a lot of third party services relied on this be able to connect and were blocked as a result we decided to revert the PR.
If someone want to hadern their XMLRPC connection they can use the following code instead.
```
add_filter( 'jpp_use_captcha_when_blocked', 'jetpack_no_captia_on_xmlrpc_requests' );
function jetpack_no_captia_on_xmlrpc_requests($allow_math_fallback) {
if( Jetpack_Constants::is_true( 'XMLRPC_REQUEST' ) ) {
return false;
}
return $allow_math_fallback;
}
```
enejb
added
the
[Status] Needs Review
samhotchkiss
added
[Status] Ready to Merge
|
LGTM |
samhotchkiss
approved these changes
Apr 13, 2018
ghost
removed
the
[Status] Ready to Merge
jeherve
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a lot of third party services relied on this be able to connect and were blocked as a result of failed login attempts we decided to revert the PR. The services will still eventually get blocked but not as quickly as they were before.
If someone want to harden their XMLRPC login they can use the following code instead.
More Context: p1HpG7-51K-p2
Reverts #8855