fix(model): set isNew to false for documents that were successfully…

… inserted by `insertMany` with `ordered = false` when an error occurred Fix #9677
Automattic · Dec 10, 2020 · 1be4d87 · 1be4d87
1 parent b2da840
commit 1be4d87
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -3332,9 +3332,13 @@ Model.$__insertMany = function(arr, options, callback) {
 
  // `insertedDocs` is a Mongoose-specific property
  const erroredIndexes = new Set(get(error, 'writeErrors', []).map(err => err.index));
- error.insertedDocs = docAttributes.filter((doc, i) => {
- return !erroredIndexes.has(i);
- });
+ error.insertedDocs = docAttributes.
+ filter((doc, i) => !erroredIndexes.has(i)).
+ map(function setIsNewForInsertedDoc(doc) {
+ doc.$__reset();
+ _setIsNew(doc, false);
+ return doc;
+ });
 
  callback(error, null);
  return;