perf: avoid unnecesary get() call and use faster approach for convert…

…ing to string Re: #14394
Automattic · Jun 17, 2024 · 2991d7b · 2991d7b
1 parent 332f7f5
commit 2991d7b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/document.js b/lib/document.js
@@ -4066,7 +4066,8 @@ Document.prototype.toObject = function(options) {
 
 function applyVirtuals(self, json, options, toObjectOptions) {
  const schema = self.$__schema;
- const paths = Object.keys(schema.virtuals);
+ const virtuals = schema.virtuals;
+ const paths = Object.keys(virtuals);
  let i = paths.length;
  const numPaths = i;
  let path;
@@ -4117,7 +4118,7 @@ function applyVirtuals(self, json, options, toObjectOptions) {
  assignPath = path.substring(options.path.length + 1);
  }
  if (assignPath.indexOf('.') === -1 && assignPath === path) {
- v = self.get(path, null, { noDottedPath: true });
+ v = virtuals[path].applyGetters(void 0, self);
  v = clone(v, options);
  if (v === void 0) {
  continue;

diff --git a/lib/helpers/schema/idGetter.js b/lib/helpers/schema/idGetter.js
@@ -27,7 +27,7 @@ module.exports = function addIdGetter(schema) {
 
 function idGetter() {
  if (this._id != null) {
- return String(this._id);
+ return this._id.toString();
  }
 
  return null;