test(query): repro #5744

Automattic · Oct 28, 2017 · 3b4211e · 3b4211e
1 parent b9ab446
commit 3b4211e
Showing 1 changed file with 31 additions and 1 deletion.
diff --git a/test/model.update.test.js b/test/model.update.test.js
@@ -2711,7 +2711,7 @@ describe('model: update:', function() {
 
  User.update({}, update, opts).exec(function(error) {
  assert.ok(error);
- assert.ok(error.errors['notifications']);
+ assert.ok(error.errors['notifications.message']);
 
  update.$pull.notifications.message = 'test';
  User.update({ _id: doc._id }, update, opts).exec(function(error) {
@@ -2726,6 +2726,36 @@ describe('model: update:', function() {
  });
  });
 
+ it('$pull with updateValidators and $in (gh-5744)', function(done) {
+ var exampleSchema = mongoose.Schema({
+ subdocuments: [{
+ name: String
+ }]
+ });
+ var ExampleModel = db.model('gh5744', exampleSchema);
+ var exampleDocument = {
+ subdocuments: [{ name: 'First' }, { name: 'Second' }]
+ };
+
+ ExampleModel.create(exampleDocument, function(error, doc) {
+ assert.ifError(error);
+ ExampleModel.updateOne({ _id: doc._id }, {
+ $pull: {
+ subdocuments: {
+ _id: { $in: [doc.subdocuments[0]._id] }
+ }
+ }
+ }, { runValidators: true }, function(error) {
+ assert.ifError(error);
+ ExampleModel.findOne({ _id: doc._id }, function(error, doc) {
+ assert.ifError(error);
+ assert.equal(doc.subdocuments.length, 1);
+ done();
+ });
+ });
+ });
+ });
+
  it('update with Decimal type (gh-5361)', function(done) {
  start.mongodVersion(function(err, version) {
  if (err) {