Merge pull request #14797 from Automattic/IslandRhythms/gh-14789

allow `mongoose.connection.db` to be undefined
Automattic · Aug 8, 2024 · 5d6463b · 5d6463b
2 parents f356452 + 7d5c845
commit 5d6463b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/test/types/connection.test.ts b/test/types/connection.test.ts
@@ -40,7 +40,7 @@ expectType<Array<string>>(conn.modelNames());
 expectType<Promise<void>>(createConnection('mongodb://127.0.0.1:27017/test').close());
 expectType<Promise<void>>(createConnection('mongodb://127.0.0.1:27017/test').close(true));
 
-expectType<mongodb.Db>(conn.db);
+expectType<mongodb.Db | undefined>(conn.db);
 
 expectType<mongodb.MongoClient>(conn.getClient());
 expectType<Connection>(conn.setClient(new mongodb.MongoClient('mongodb://127.0.0.1:27017/test')));
@@ -65,7 +65,7 @@ expectError(conn.host = 'invalid');
 expectError(conn.port = 'invalid');
 
 expectType<Collection>(conn.collection('test'));
-expectType<mongodb.Collection>(conn.db.collection('test'));
+expectType<mongodb.Collection | undefined>(conn.db?.collection('test'));
 
 expectType<Promise<mongodb.ClientSession>>(conn.startSession());
 expectType<Promise<mongodb.ClientSession>>(conn.startSession({ causalConsistency: true }));

diff --git a/types/connection.d.ts b/types/connection.d.ts
@@ -72,7 +72,7 @@ declare module 'mongoose' {
     readonly config: any;
 
     /** The mongodb.Db instance, set when the connection is opened */
-    readonly db: mongodb.Db;
+    readonly db: mongodb.Db | undefined;
 
     /**
      * Helper for `createCollection()`. Will explicitly create the given collection