perf: correct way to avoid calling concat() re: #11380

Automattic · Nov 24, 2023 · 62d5302 · 62d5302
1 parent e3cccc3
commit 62d5302
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/lib/types/array/methods/index.js b/lib/types/array/methods/index.js
@@ -374,7 +374,13 @@ const methods = {
       if (val != null && utils.hasUserDefinedProperty(val, '$each')) {
         atomics.$push = val;
       } else {
-        atomics.$push.$each.push(val);
+        if (val.length < 10000) {
+          atomics.$push.$each.push(...val);
+        } else {
+          for (const v of val) {
+            atomics.$push.$each.push(v);
+          }
+        }
       }
     } else {
       atomics[op] = val;
@@ -711,7 +717,7 @@ const methods = {
           'with different `$position`');
       }
       atomic = values;
-      ret = [].push.apply(arr, values);
+      ret = _basePush.apply(arr, values);
     }
 
     this._registerAtomic('$push', atomic);