Merge pull request #14735 from Automattic/vkarpov15/gh-14660

types: make `_id` required on Document type
Automattic · Jul 10, 2024 · b8f0109 · b8f0109
2 parents bc13f15 + 779bfe5
commit b8f0109
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/test/types/docArray.test.ts b/test/types/docArray.test.ts
@@ -91,7 +91,7 @@ async function gh13424() {
  const TestModel = model('Test', testSchema);
 
  const doc = new TestModel();
- expectType<Types.ObjectId | undefined>(doc.subDocArray[0]._id);
+ expectType<Types.ObjectId>(doc.subDocArray[0]._id);
 }
 
 async function gh14367() {

diff --git a/test/types/schema.test.ts b/test/types/schema.test.ts
@@ -1386,7 +1386,7 @@ function gh13424() {
  const TestModel = model('TestModel', new Schema(testSchema));
 
  const doc = new TestModel({});
- expectType<Types.ObjectId | undefined>(doc.subDocArray[0]._id);
+ expectType<Types.ObjectId>(doc.subDocArray[0]._id);
 }
 
 function gh14147() {

diff --git a/types/document.d.ts b/types/document.d.ts
@@ -22,7 +22,7 @@ declare module 'mongoose' {
  constructor(doc?: any);
 
  /** This documents _id. */
- _id?: T;
+ _id: T;
 
  /** This documents __v. */
  __v?: any;