test: fix some code review comments

Automattic · May 18, 2023 · cc2adec · cc2adec
1 parent bb9bc35
commit cc2adec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/model.js b/lib/model.js
@@ -3410,7 +3410,7 @@ Model.bulkWrite = async function bulkWrite(ops, options) {
           results[validOpIndexes[i]] = null;
         }
         if (validationErrors.length > 0) {
-          if ('throwOnValidationError' in options && options.throwOnValidationError) {
+          if (options.throwOnValidationError) {
             return reject(new MongooseBulkWriteError(
               validationErrors,
               results,

diff --git a/test/model.test.js b/test/model.test.js
@@ -6237,6 +6237,9 @@ describe('Model', function() {
       assert.equal(err.validationErrors[0].errors['age'].name, 'CastError');
       assert.ok(err.results[2] instanceof Error);
       assert.equal(err.results[2].errors['age'].name, 'CastError');
+
+      const docs = await User.find();
+      assert.deepStrictEqual(docs.map(doc => doc.age), [12, 12]);
     });
 
     it('returns writeResult on success', async() => {