-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
2 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9163f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to this change we no longer set the super-class's
message
property (it just remains an empty string as set on line 20.d9163f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dskrvk can you please elaborate on your comment? I don’t understand
d9163f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant that because the "base constructor" is now called on line 22 before we set
this._message
, which feeds into the publicly-accessiblemessage
property in the base class,message
is now always an empty string. It would be nice for it to contain something useful like before. I'm just trying to understand if this was intentional.d9163f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dskrvk nope that sounds like an issue. .Can you please open up a new issue with code samples that demonstrate the behavior you're seeing?