-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The return type of connection.tranaction method should not be Promise<void>. #14656
Closed
2 tasks done
Labels
typescript
Types or Types-test related issue / Pull Request
Milestone
Comments
IslandRhythms
added
the
typescript
Types or Types-test related issue / Pull Request
label
Jun 10, 2024
vkarpov15
added a commit
that referenced
this issue
Jun 10, 2024
vkarpov15
added a commit
that referenced
this issue
Jun 11, 2024
types(connection): make transaction() return type match the executor function
This was referenced Jul 30, 2024
This was referenced Jul 30, 2024
This was referenced Aug 2, 2024
This was referenced Sep 1, 2024
This was referenced Sep 3, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Mongoose version
8.2.4
Node.js version
20.12.2
MongoDB server version
The latest version
Typescript version (if applicable)
5.4.3
Description
mongoose/types/connection.d.ts
Line 239 in c71ba5e
The return type of method
connection.prototype.transaction
should not bePromsie<void>
.Steps to Reproduce
.
Expected Behavior
It should use the correct return type.
The text was updated successfully, but these errors were encountered: