Update from 8.8.2 to 8.8.3 causes "Uncaught TypeError: Invalid path. Must be either string or array"

[christian-schwaderer]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Mongoose version

8.8.3

Node.js version

20.18.0

MongoDB server version

7

Typescript version (if applicable)

No response

Description

I tried upgrading Mongoose from 8.8.2 to 8.8.3. But when trying to create a document I got this issue:

Uncaught TypeError: Invalid `path`. Must be either string or array
      at Object.exports.get (node_modules/mpath/lib/index.js:59:11)
      at Object.exports.getValue (Role node_modules/mongoose/lib/utils.js:624:16)
      at model.Document.$__getValue (Role node_modules/mongoose/lib/document.js:1771:16)
      at getSubdocs (Role node_modules/mongoose/lib/document.js:3695:23)
      at model.Document.$getAllSubdocs (Role node_modules/mongoose/lib/document.js:3723:3)
      at _getPathsToValidate (Role node_modules/mongoose/lib/document.js:2714:25)
      at model.Document.$__validate (Role node_modules/mongoose/lib/document.js:2980:25)
      at node_modules/kareem/index.js:497:25
      at processTicksAndRejections (node:internal/process/task_queues:77:11)

Tried to look a little bit and it seems that the problematic line is for (const { path } of doc.$__schema.childSchemas) {
It seems my schema has a paths property but not a path property and hence an undefined value is passed down. But that's where my knowledge ends. Cannot say how come.

Steps to Reproduce

Sorry but I cannot paste hundreds of lines of company code in here. I have no idea where in my schema the problem is.

Expected Behavior

No response

[hansgen]

We're experiencing the same issue.

[maximilianschmid]

Same here

[vkarpov15]

Without a repro script there's no way for us to guarantee a fix, but in #15098 we added some logic to improve this error message and a potential (but unlikely) fix. Can anyone in this thread please provide a script that demonstrates this issue or some sample code that can give us some hints?

[christian-schwaderer]

Boy, that took a few hours ... Here we go https://github.com/christian-schwaderer/mongoose-8-8-3-invalid-path-demo
Just clone and run node index.js

Edit: The script expects a Mongo instance running on mongodb://127.0.0.1:27017

[vkarpov15]

@christian-schwaderer the issue is due to the fact that your foo module uses Mongoose 8.8.3, but your top-level module uses Mongoose 8.5.2. I managed to repro this issue locally with a similar setup.

Is there anything preventing you from upgrading your top-level module to Mongoose 8.8.3? We will see what we can do to fix this particular issue, but it is worth noting that you should keep your Mongoose versions consistent between shared packages, because we don't test that, for example, schemas from Mongoose 8.5 work with models from Mongoose 8.8.

[vkarpov15]

Still working on a fix, this is a bit tricky because we need to effectively implement two separate $getAllSubdocs(), one for the normal case and one for the "pre 8.8 mongoose Schema, post 8.8 mongoose model" case.