document.remove() removes whole collection

[RBLU]

I think this commit (caf7181) for a fix of model.remove() has triggered that now when we call:

document.remove(cb) 

everything in the collection is removed, previously only the one document was removed.
This can be pretty bad (my users collection was emtpy after deleting one user)... I hope my analysis is not correct.

Also the documentation here states clearly that the current behaviour is not intended: http://mongoosejs.com/docs/api.html#model_Model-remove
model.remove(fn) removes this document from the db.

[vkarpov15]

Whoa yeah that's not terribly good. On it.

[fyockm]

duplicate of #3325

[farhanpatel]

This fix should be out now. This is pretty huge

[vkarpov15]

Done. Thanks.

[Martii]

@vkarpov15
Perhaps a silly question... but is there an "unremove" (undelete) method?

[shauntrennery]

This got me this morning. Thank goodness for database backups. All our platform's apps were deleted. I even started to suspect we had been hacked.

[vkarpov15]

Sorry about that @shauntrennery - unfortunately we did not have test coverage for this situation and the fix for #3235 went awry. 4.1.4 has been unpublished so hopefully that'll limit the possibility of anybody running into this again...

@Martii not that I know of unfortunately. Typically it's a better choice to not explicitly delete individual docs and instead hide them behind an isDeleted flag for this sort of situation.