-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-compile mongoose/browser #7219
Comments
Here's a really good guide on how to do this: |
So in my monorepo project I just finally got around to setting up a child package that depends on mongoose and builds it with webpack, and I was thinking about PRing something, but I realized my goals probably aren't the same as other people's and this would warrant more discussion first. I'm not sure how it's possible to satisfy everyone's needs with this. To illustrate what I mean, I'll paste the webpack config I'm using and why...
As you can see, it's not all too different from the webpack test, but:
So in my case, webpack needs to do very little. I have a feeling these goals might even be contradictory to what was in mind for this issue. Unless I'm missing something, I'm not sure how to make everyone happy without actually having at least two different mongoose-browser versions :-/. Or maybe my goals are just too specific for the scope of this issue. Even so, there are some questions as to how it should be organized (where it should be output, testing, etc). I'd be happy to pitch in if you have some guidance for me. |
Since I never heard back about specifics, I decided to just throw together a PR - if any of the details need work I'll just address them thereafter ;). |
should this issue be closed because #8350 is merged? |
So people don't have to merge their webpack config with Mongoose's recommended config. Re: discussion from #6826 (comment)
The text was updated successfully, but these errors were encountered: