Export a Separate Type for PipelineStage Types Allowed in Facet Aggregation Sub-Pipelines #11150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a typescript type-only change.
Currently, the type definition for each sub-pipeline within a
{ $facet: ... }
aggregation pipeline stage is baked in to the overall definition of the Facet stage.We've got a situation where we'd like to pass these sub-pipeline arrays around, ideally in a type-safe way. Currently, that requires a bit of boilerplate to keep typescript happy; with this change, we should just be able to say, for example:
Happy to change the name of this type if
FacetPipelineStage
doesn't make sense.Thank you for the great project 😀