fix(document): allow populating deeply nested models as strings #11168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b41cd1e.
vkarpov15
requested changes
Jan 3, 2022
AbdelrahmanHafez
commented
Jan 3, 2022
|
@vkarpov15 |
|
@vkarpov15, at first I also thought that this check is needed. But then I looked around the code and realized that this check was unnecessary. Line 4614 already excludes falsy values. Is not it? |
|
@Kamikadze4GAME is right, thanks for pointing that out. I'll merge this and fix in master so we can get this out. |
vkarpov15
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11160
@vkarpov15
This change means that we won't report the full path if a user uses
populate: 'websiteId'because we can't assign a property to a string.Can you think of a way to overcome this?
Even with this caveat, I think it's best we have populate in the first place, then we can work on improving the error message being reported.