fix Node.js 17.5 compatibility

[benjamingr]

The tc39 async iterator helpers spec adds .map to async iterators and Node added support for that.

As part of spec compliance Node uses defineProperty to add these properties.

This PR fixes setting .map in Mongoose over the property.

As a side note: it might make sense for Mongoose to deprecate .map since it's mutative which makes it named the same but with a different behavior from the tc39 iterator helpers proposal .map

Fixes: #11377

[nateevans]

FYI - this change works, I used it as a patch, but the same issue exists here
https://github.com/Automattic/mongoose/blob/master/lib/cursor/AggregationCursor.js#L140

[benjamingr]

Thanks @nateevans anywhere else?

[nateevans]

I'll let you know, actively going through it now

[benjamingr]

Feel free to push to this branch or PR it if pushing directly doesn't work

[nateevans]

@benjamingr that seems to be the 2 files with the issue

[Uzlopak]

@benjamingr

Can you please run the lint fixer over your code?

npm run lint -- --fix

[benjamingr]

@Uzlopak sure done

[Slayer95]

Here it should be enumerable and configurable, shouldn't it?

[benjamingr]

@Slayer95 probably not unless you think people are expecting it to show up on for… in loops

[Slayer95]

I mean, the current implementation does that, so the fix should keep it. Otherwise, it might be the better plan to update all methods to your approach.

Just pointing that out. Maintainer shall know better.

[vkarpov15]

Thanks 👍 I'll make these properties enumerable and writable in master, if possible.

[Eunit99]

This fix does not resolve #11377 as claimed. I had to downgrade my NodeJS to version 12.x. to resolve #11377. More information on how I did that is found in this tutorial.

[Uzlopak]

Your tutorial is missing the point. Downgrading to node 12 is like saying: Hey your Tesla needs Electricity, but to still use gasoline use a Ford Model-T. Despite the fact you could use a modern car, which uses gasoline.

Also our CI/CD Pipelines is testing for node18, which actually would fail if that issue was still existing. But the patch by @benjamingr is solving that issue also for node18.

So to solve that issue, you would need to upgrade mongoose to latest version OR use any version of node 17 except 17.5.0 and node 18 and above. A downgrade to node 12 is not necessary.

And mongoose 6.3.2 does not has that issue, which you describe.