-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[✔️] Auto-typed-virtuals #11908
[✔️] Auto-typed-virtuals #11908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, looks good so far though
Hello @vkarpov15 @Uzlopak! Please review this when you have time for that, I need to add some details in docs, and It will be done I think. |
15c50ab
to
ea16fd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of quick notes. I'll review this more later.
6317e97
to
8fa7bcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohammad0-0ahmad LGTM minus merge conflicts. I changed the branch to 6.5.
Alright I will fix that, and complete this PR. |
6775995
to
94cd381
Compare
…ns while creating virtual path.
fa12e62
to
4741531
Compare
4741531
to
f5983e6
Compare
507823c
to
917d331
Compare
Related to auto-typed mongoose.
#11563