Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend types test for #11960 #12001

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Extend types test for #11960 #12001

merged 2 commits into from
Jul 1, 2022

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Jun 28, 2022 •
edited
Loading

Summary

This PR extends the types test that was initially added for #11960, with more tests and another case

WARNING: this PR is currently set to fail because of the new case, so i dont think it is good to merge it yet

Edit:
the first commit extends the initial test case to actually test what the reproduction repository of the mentioned issue had problematic
the second commit duplicates the test for new to also test create (which was not updated yet)

@hasezoey hasezoey mentioned this pull request Jun 28, 2022
Closed
2 tasks
@vkarpov15 vkarpov15 added this to the 6.4.2 milestone Jul 1, 2022
vkarpov15
vkarpov15 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I'll put in a fix for this in master

@vkarpov15 vkarpov15 merged commit 39f651c into Automattic:master Jul 1, 2022
vkarpov15 added a commit that referenced this pull request Jul 1, 2022
@vkarpov15
fix(types): avoid inferring doc type from param to create()
9ba3f12 
Fix #12001
Re: #11960
Re: #11563
@vkarpov15 vkarpov15 mentioned this pull request Jul 1, 2022
Closed
2 tasks
@hasezoey hasezoey deleted the extendTypesTestFor11960 branch July 2, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hasezoey @vkarpov15