Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update migrating_to_6.md #12123

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Update migrating_to_6.md #12123

merged 1 commit into from
Jul 19, 2022

Conversation

LokeshKanumoori
Copy link
Contributor

correct the proof/example statement of isObjectIdOrHexString

@LokeshKanumoori
Update migrating_to_6.md
1344214 
correct the proof/example statement of isObjectIdOrHexString
Uzlopak
Uzlopak approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak
Copy link
Collaborator

Uzlopak commented Jul 19, 2022

Wait a second. Why should this be wrong?

@Uzlopak Uzlopak self-requested a review July 19, 2022 13:49
vkarpov15
vkarpov15 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.4.6 milestone Jul 19, 2022
@vkarpov15 vkarpov15 merged commit b70a0dc into Automattic:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@LokeshKanumoori @Uzlopak @vkarpov15