Chore: Add test for auto typed approach. #12207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammad0-0ahmad
changed the title
mohammad0-0ahmad
force-pushed
the
auto-typed-tests
branch
4 times, most recently
from
7deffeb to
b1691a2
Compare
mohammad0-0ahmad
force-pushed
the
auto-typed-tests
branch
from
b1691a2 to
619ffa4
Compare
vkarpov15
requested changes
Sep 12, 2022
| @@ -0,0 +1,37 @@ | |||
| name: TypeScript Benchmark "auto-typed-mongoose" | |||
There was a problem hiding this comment.
Let's keep this in the benchmark.yml file to minimize overhead. Just add 2 extra steps to npm install and run ts-benchmark in auto-typed directory.
|
I'm going to close this PR for now, it is long out of date and I'm not sure it is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10349 (comment)
Note: the new added test fails because the test folder "benchmarks\typescript\auto-typed" doesn't exist in master branch yet.
It should work as it should when target master and targeted branch does have the mentioned test folder.