fix(schema): copy indexes when calling add() with schema instance
#12737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
hasezoey,
AbdelrahmanHafez and
IslandRhythms
AbdelrahmanHafez
approved these changes
Nov 30, 2022
rdeavila94
added a commit
to rdeavila94/mongoose
that referenced
this pull request
Mar 6, 2023
…ticgh-12654 fix(schema): copy indexes when calling `add()` with schema instance
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12654
Summary
Docs say that
Schema.prototype.add()copies indexes if you calladd()with a schema instance, but looks like that doesn't actually happen. I can see the case for putting this change in a minor release, but I think patch is fine since the docs indicate that this is the correct behavior.Examples