fix(merge): allow array fields to be merged #12945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Burke <jonathan.burke.1311@googlemail.com>
Rouby
force-pushed
the
Rouby/fix-12944
branch
from
b217b28 to
6bf48c8
Compare
vkarpov15
reviewed
Feb 3, 2023
There was a problem hiding this comment.
I don't think we can merge this particular change, changing utils.merge() for this one case is a bit too risky. For example, we also use merge() to merge query options and query updates, and we don't necessarily want to merge array options or arrays in updates.
I'm not saying that #12944 isn't something we can't fix, but this particular implementation is unfortunately not something we can merge. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue mentioned in #12944