Updated the isIndexEqual function to take into account non-text index… #13138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeavila94
commented
Mar 6, 2023
| @@ -28,15 +28,19 @@ module.exports = function isIndexEqual(key, options, dbIndex) { | |||
| // textIndexVersion: 3 | |||
There was a problem hiding this comment.
A compound index with text and non-text fields will look like this:
{ name: 'text', age:1 } becomes:
{
v: 2,
key: { _fts: 'text', _ftsx: 1, age: 1 },
name: 'name_text_age_1',
ns: 'test.tests',
background: true,
weights: { name: 1 },
default_language: 'english',
language_override: 'language',
textIndexVersion: 3
}Currently, we are comparing the weights agains the entire key set, here
But the key arg into this function consists of ALL the keys, whereas the weights only include the text-indexed keys.
…es when checking compound indexes that include both text and non-text indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es when checking compound indexes that include both text and non-text indexes
Summary
This PR fixes #13136