fix(array): track correct changes when setting nested array of primitives #13422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
hasezoey
approved these changes
May 21, 2023
AbdelrahmanHafez
approved these changes
May 21, 2023
Uzlopak
reviewed
May 22, 2023
Uzlopak
reviewed
May 22, 2023
Co-authored-by: Hafez <a.hafez852@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13372
Summary
The problem is that, for nested arrays of primitives, the array's internal path is
intArr.$rather thanintArr.0. This causes problems when trying to set the path directly, because then Mongoose marksintArr.$.0as modified.Examples