fix(document): clean up all array subdocument modified paths on save() #13589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
force-pushed
the
vkarpov15/gh-13582
branch
from
b258914 to
422dff4
Compare
AbdelrahmanHafez
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13582
Summary
#13582 points out that we didn't correctly clear
modifiedPaths()on array subdocuments, other than the first subdocument in the array. This PR fixes that, but it looks like the fix for #6818 succeeded because of the buggy behavior. So we added some new logic to explicitly validate the parent array if making changes underneath a document array.Examples