set default value for _update when no update object is provided and versionKey is set to false #13795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersionKey is set to false
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Valeriu-Andrei Florescu <49231993+valeriuflorescu16@users.noreply.github.com>
…b.com/MohOraby/mongoose into fix/findOneAndUpdate-no-update-object
AbdelrahmanHafez
approved these changes
Aug 30, 2023
valeriuflorescu16
approved these changes
Aug 31, 2023
MohOraby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13783
When calling
findOneAndUpdatewith no update query the_decorateUpdateWithVersionKeyfunction adds'$setOnInsert': { __v: 0 }to the update doc so it passes the_mergeUpdatefirst check which then sets the_updateto{}but withversionKeyset tofalsethe update doc length is 0 so the_mergeUpdatefunction returns earlythis PR set a value of empty object to the
_updateproperty even whenObject.keys(doc).length === 0so it's defined