Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): throw readable error when calling Model() with a string instead of model() #14288

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(model): throw readable error when calling Model() with a string instead of model() #14288

merged 1 commit into from
Jan 24, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14281

Summary

Quick improvement to error message, related work #2005.

Examples

IslandRhythms
IslandRhythms approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 added this to the 8.1.1 milestone Jan 24, 2024
@vkarpov15 vkarpov15 merged commit 0d54bea into master Jan 24, 2024
34 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14281 branch January 24, 2024 22:16
@mnathsnyk mnathsnyk mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IslandRhythms IslandRhythms IslandRhythms approved these changes

@hasezoey hasezoey Awaiting requested review from hasezoey

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.1
Development

Successfully merging this pull request may close these issues.

TypeError: this.$__setSchema is not a function
2 participants
@vkarpov15 @IslandRhythms