-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model): add recompileSchema()
function to models to allow applying schema changes after compiling
#14306
Conversation
…ying schema changes after compiling Fix #14296
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, otherwise LGTM. Thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though the jsdoc return type is wrong and addition to typescript types is missing
Co-authored-by: hasezoey <hasezoey@gmail.com>
Merging into 8.2 |
Fix #14296
Summary
Making changes to schemas after compiling a model is a common feature request. We can support that by adding an extra model function
recompileSchema()
that applies schema changes after model compilation.Examples