types: consistently infer array of objects in schema as a DocumentArray #14430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14367
Summary
The root cause of #14367 looks to be a minor inconsistency in type inference: on L232 we had
ObtainDocumentType<Item, any, { typeKey: TypeKey }>[], and on L238 we haveTypes.DocumentArray<ObtainDocumentType<Item, any, { typeKey: TypeKey }>>. If these 2 are consistent, the code from #14367 compiles. Not 100% sure why, but we have tests proving this does the right thing.Examples