fix(types/query): bring "getFilter" and "getQuery" in-line with "find" and other types #14463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" and other types change "DocType" -> "RawDocType"
This was referenced Mar 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes
Query.getFilterandQuery.getQueryto useRawDocTypeagain, as this is the same argument as in.find'sfilterparameter.In addition also pass-through the
QueryHelpersandDocTypeinSchemaOptions'squery's object (otherwise there is a test failure).This change from e3f3205 somehow made it so that
PopulatedDoc<Document, RefType>could not be narrowed down to the usedRefTypeanymore, and i dont know why, but this change fixed it again for typegoose.