fix(model): make `Model.recompileSchema()` also re-apply discriminators #14500

vkarpov15 · 2024-04-04T21:47:08Z

Summary

Right now recompileSchema() applies most schema changes, but not additional Schema.prototype.discriminator() or SchemaType.prototype.discriminator() calls. This PR makes recompileSchema() go through and reapply every discriminator that was added to the schema.

Examples

Fix #14444

hasezoey

Looks good, though some test nitpicks

lib/model.js

test/model.test.js

fix(model): make Model.recompileSchema() also re-apply discriminators

c8d6acf

Fix #14444

vkarpov15 requested review from hasezoey and AbdelrahmanHafez April 4, 2024 21:47

docs: quick correction to avoid claiming that an Error is a string

2db8430

hasezoey requested changes Apr 6, 2024

View reviewed changes

lib/model.js Outdated Show resolved Hide resolved

test/model.test.js Outdated Show resolved Hide resolved

test/model.test.js Outdated Show resolved Hide resolved

test/model.test.js Outdated Show resolved Hide resolved

test/model.test.js Show resolved Hide resolved

fix: address code review comments

1e8753f

vkarpov15 merged commit b729474 into master Apr 7, 2024
34 checks passed

vkarpov15 added this to the 8.3.1 milestone Apr 7, 2024

vkarpov15 deleted the vkarpov15/gh-14444 branch April 7, 2024 21:47

Marion-Rld mentioned this pull request May 18, 2024

[Snyk] Upgrade mongoose from 8.3.1 to 8.3.2 Marion-Rld/projet-staffme-back#2

Open

MihikaNigam mentioned this pull request May 19, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.3.2 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#54

Open

nejidevelops mentioned this pull request May 19, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.3.2 nejidevelops/expense-tracker#9

Open

Gabo-Tech mentioned this pull request May 19, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.3.2 Gabo-Tech/toDoList#279

Open

YohanChabiduPerera mentioned this pull request May 19, 2024

[Snyk] Upgrade mongoose from 8.3.0 to 8.3.2 IT21042324/Post-Management-Microservice#9

Open

akanchhaS mentioned this pull request May 19, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.3.2 akanchhaS/github-goof-npm#1202

Open

Erenkrs mentioned this pull request May 19, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.2 Erenkrs/Uptime-Site#190

Open

Gabo-Tech mentioned this pull request May 20, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.3.3 Gabo-Tech/toDoList#280

Open

lholmquist mentioned this pull request May 20, 2024

[Snyk] Upgrade mongoose from 6.12.0 to 8.3.3 nodeshift/mern-workshop#196

Closed

Erenkrs mentioned this pull request May 20, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.3 Erenkrs/Uptime-Site#195

Open

nejidevelops mentioned this pull request May 20, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.3.3 nejidevelops/expense-tracker#10

Open

MihikaNigam mentioned this pull request May 21, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.3.3 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#56

Open

akanchhaS mentioned this pull request May 21, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.3.3 akanchhaS/github-goof-npm#1203

Open

NotZarifGithub mentioned this pull request May 21, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.3.3 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#78

Open

shazamakash1 mentioned this pull request May 22, 2024

[Snyk] Upgrade mongoose from 8.2.2 to 8.3.3 shazamakash1/MERNSTACK_UPDATED#2

Open

mihirhbhatt mentioned this pull request May 22, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.3.3 mihirhbhatt/devops-essentials-main#126

Merged

Erenkrs mentioned this pull request May 22, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.3 Erenkrs/Uptime-Site#200

Open

IdrizMirena mentioned this pull request May 22, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.3.3 IdrizMirena/SmartCloudAI#3

Open

olexiyb mentioned this pull request May 22, 2024

[Snyk] Upgrade mongoose from 8.0.3 to 8.3.3 rootscan/rootscan-io#72

Closed

nhattpn mentioned this pull request May 23, 2024

[Snyk] Upgrade mongoose from 8.3.1 to 8.3.3 nhattpn/BTL_LTNC#27

Closed

nejidevelops mentioned this pull request May 24, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.3.3 nejidevelops/expense-tracker#11

Open

Gabo-Tech mentioned this pull request May 24, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.3.3 Gabo-Tech/toDoList#281

Open

NotZarifGithub mentioned this pull request May 24, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.3.3 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#84

Open

Erenkrs mentioned this pull request May 24, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.3 Erenkrs/Uptime-Site#205

Open

MihikaNigam mentioned this pull request May 24, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.3.3 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#59

Open

Erenkrs mentioned this pull request May 26, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.3 Erenkrs/Uptime-Site#210

Open

boytur mentioned this pull request May 26, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.3 boytur/server-posyayee-v1#53

Open

This was referenced May 26, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.3 Erenkrs/Uptime-Site#215

Open

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.3 Erenkrs/Uptime-Site#220

Open

akanchhaS mentioned this pull request May 27, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.3.4 akanchhaS/github-goof-npm#1212

Open

Safar123 mentioned this pull request May 28, 2024

[Snyk] Upgrade mongoose from 8.3.1 to 8.3.4 Safar123/Recipe_Manager#7

Open

nejidevelops mentioned this pull request May 28, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.3.4 nejidevelops/expense-tracker#16

Open

MihikaNigam mentioned this pull request May 28, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.3.4 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#70

Open

boytur mentioned this pull request May 28, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.4 boytur/server-posyayee-v1#58

Open

NotZarifGithub mentioned this pull request May 28, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.3.4 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#89

Open

Erenkrs mentioned this pull request May 29, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.4 Erenkrs/Uptime-Site#225

Open

Gabo-Tech mentioned this pull request May 29, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.3.4 Gabo-Tech/toDoList#286

Open

nhattpn mentioned this pull request May 29, 2024

[Snyk] Upgrade mongoose from 8.3.1 to 8.3.4 nhattpn/BTL_LTNC#31

Closed

Erenkrs mentioned this pull request May 29, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.4 Erenkrs/Uptime-Site#230

Open

lholmquist mentioned this pull request May 30, 2024

[Snyk] Upgrade mongoose from 6.12.0 to 8.3.4 nodeshift/mern-workshop#205

Closed

hatifmujahid mentioned this pull request May 30, 2024

[Snyk] Upgrade mongoose from 8.2.1 to 8.3.4 hatifmujahid/devdayserver#8

Merged

Erenkrs mentioned this pull request May 30, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.3.4 Erenkrs/Uptime-Site#235

Open

pasang7 mentioned this pull request May 30, 2024

[Snyk] Upgrade mongoose from 8.3.1 to 8.3.4 pasang7/Recipe-Manager-Server#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(model): make `Model.recompileSchema()` also re-apply discriminators #14500

fix(model): make `Model.recompileSchema()` also re-apply discriminators #14500

vkarpov15 commented Apr 4, 2024

hasezoey left a comment

fix(model): make Model.recompileSchema() also re-apply discriminators #14500

fix(model): make Model.recompileSchema() also re-apply discriminators #14500

Conversation

vkarpov15 commented Apr 4, 2024

hasezoey left a comment

Choose a reason for hiding this comment

fix(model): make `Model.recompileSchema()` also re-apply discriminators #14500

fix(model): make `Model.recompileSchema()` also re-apply discriminators #14500