-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(error): remove model property from CastError to avoid printing all model properties to console #14568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l model properties to console Fix #14529
hasezoey
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just consider maybe putting this in the next minor version instead of a patch
I agree @hasezoey |
This was referenced Jun 7, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14529
Summary
The following script currently prints > 10k lines of output:
Because
CastError
contains the full model, and Node.js'inspect()
seems to ignore custom inspect handlers for error instances. So the above script prints outTestModel
and all its subprops, including connections and connection strings in plaintext. This is a bit of a nasty surprise as we saw in #14529.I did a bunch of digging to try to find some way to get Node's error formatting to avoid printing
model
, the only approach that seems to work is makingmodel
a getter and storing the actual mapping of error -> model in a WeakMap. However that seems a bit excessive.Examples