feat: add transactionAsyncLocalStorage option to opt in to automatically setting session on all transactions
#14583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cally setting `session` on all transactions Fix #13889
hasezoey
requested changes
May 12, 2024
There was a problem hiding this comment.
Mostly looks good to me, though one minor code example thing and failing Replica set tests because of this PR (this time not because of watch errors)
test error for reference:
1) transactions
transactionAsyncLocalStorage option
transaction() sets `session` by default if transactionAsyncLocalStorage option is set:
AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Oops!/. Input:
'AssertionError [ERR_ASSERTION]: 0 == 1'
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Context.<anonymous> (test/docs/transactions.test.js:374:7)
hasezoey
added
the
new feature
Co-authored-by: hasezoey <hasezoey@gmail.com>
hasezoey
approved these changes
May 14, 2024
This was referenced Jun 7, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13889
Summary
Having to pass
sessionoption to every operation in a transaction is cumbersome and error prone. Node 16+ has a stable AsyncLocalStorage class as part of the async_hooks API; we can use AsyncLocalStorage to setsessionoption by default on all operations in a function as long as the user usesConnection.prototype.transaction()wrapper. Seedocs/transactions.mdchanges for an example.Examples