fix(document): fire pre validate hooks on 5 level deep single nested subdoc when modifying after save() #14604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subdoc when modifying after save() Fix #14591
hasezoey
approved these changes
May 18, 2024
This was referenced Jun 22, 2024
This was referenced Jun 22, 2024
This was referenced Jul 17, 2024
This was referenced Jul 18, 2024
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14591
Summary
Tricky issue: if you
save()a doc, thenset()a more than 3 level nested single nested path using dot notation, pre('validate') hooks don't fire because the subdoc paths aren't marked as modified beyond the 1st level.This PR provides a reasonable fix for this particular case, but I will look more closely at how our change tracking handles subdocs as a followup to this work.
Examples