Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass options to clone instead of get in applyVirtuals. #14606

Merged
merged 1 commit into from
May 24, 2024
Merged

Pass options to clone instead of get in applyVirtuals. #14606

merged 1 commit into from
May 24, 2024

Conversation

andrews05
Copy link
Contributor

@andrews05 andrews05 commented May 20, 2024 •
edited
Loading

Summary

A bug introduced in v8.3.3 by #14543 caused toJSON to not be executed for virtual sub documents. The issue is caused by the options being incorrectly passed into the get function instead of the clone function.

Examples

I don't have an easy examples sorry, but I think the fix should be fairly evident. The intentions of #14543 was to pass noDottedPath: true to the get function but it mistakenly included the clone options which should have been passed to clone instead, as on line 4139 below it.

@vkarpov15 vkarpov15 added this to the 8.4.1 milestone May 24, 2024
vkarpov15
vkarpov15 approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch, thank you!

@vkarpov15 vkarpov15 merged commit 53362c3 into Automattic:master May 24, 2024
18 checks passed
@andrews05 andrews05 deleted the fix/virtuals-fast-path branch May 27, 2024 00:31
@vkarpov15 vkarpov15 mentioned this pull request May 30, 2024
Merged
vkarpov15 added a commit that referenced this pull request May 31, 2024
@vkarpov15
fix: quick fix for #14606 pulled in from #14623
e370f72
@saileshbro saileshbro mentioned this pull request Jun 21, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Jun 21, 2024
Open
@Pratham-Darji Pratham-Darji mentioned this pull request Jun 21, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 21, 2024
Open
@nhattpn nhattpn mentioned this pull request Jun 21, 2024
Closed
@WahajJaved20 WahajJaved20 mentioned this pull request Jun 21, 2024
Open
@kumararvind10 kumararvind10 mentioned this pull request Jun 21, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 21, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 21, 2024
Open
@Bapparajsk Bapparajsk mentioned this pull request Jun 21, 2024
Open
@WilsonSue WilsonSue mentioned this pull request Jun 21, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 21, 2024
Open
@tuanicom tuanicom mentioned this pull request Jun 22, 2024
Merged
@parth5924 parth5924 mentioned this pull request Jun 22, 2024
Open
@maporto maporto mentioned this pull request Jun 22, 2024
Open
This was referenced Jun 22, 2024
Merged
Merged
@paulbland paulbland mentioned this pull request Jun 22, 2024
Open
@CedricTheveneau CedricTheveneau mentioned this pull request Jun 22, 2024
Closed
@saileshbro saileshbro mentioned this pull request Jun 22, 2024
Merged
This was referenced Jun 22, 2024
Open
Open
@marck283 marck283 mentioned this pull request Jun 22, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Aug 4, 2024
Open
@CarlosMHF CarlosMHF mentioned this pull request Aug 4, 2024
Open
This was referenced Aug 5, 2024
Open
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Aug 6, 2024
Open
@DevexHub121 DevexHub121 mentioned this pull request Aug 7, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 7, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 7, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 8, 2024
Open
@Zambrana29 Zambrana29 mentioned this pull request Aug 8, 2024
Open
@solitariusdigital solitariusdigital mentioned this pull request Aug 8, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Aug 9, 2024
Open
@Zambrana29 Zambrana29 mentioned this pull request Aug 9, 2024
Open
@lholmquist lholmquist mentioned this pull request Aug 10, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Aug 10, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Aug 10, 2024
Open
@shinjini20 shinjini20 mentioned this pull request Aug 11, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 11, 2024
Open
@vky5 vky5 mentioned this pull request Aug 12, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Aug 13, 2024
Open
@lholmquist lholmquist mentioned this pull request Aug 13, 2024
Closed
@zntb zntb mentioned this pull request Aug 15, 2024
Merged
@clifford-snyk-github clifford-snyk-github mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 15, 2024
Open
Open
@ELProfessor67 ELProfessor67 mentioned this pull request Aug 16, 2024
Open
@Ahad-webdev-90 Ahad-webdev-90 mentioned this pull request Aug 17, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Aug 17, 2024
Open
This was referenced Aug 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@andrews05 @vkarpov15