-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure buildBulkWriteOperations target shard if shardKey is set #14621
Merged
vkarpov15
merged 1 commit into
Automattic:master
from
priceshape-development:fix/add-shard-key-to-bulk-write-operations
May 30, 2024
Merged
fix: ensure buildBulkWriteOperations target shard if shardKey is set #14621
vkarpov15
merged 1 commit into
Automattic:master
from
priceshape-development:fix/add-shard-key-to-bulk-write-operations
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matlpriceshape
changed the title
Make sure buildBulkWriteOperations target shard if shardKey is set
fix: ensure buildBulkWriteOperations target shard if shardKey is set
May 30, 2024
vkarpov15
approved these changes
May 30, 2024
Thanks 👍 |
This was referenced Jun 22, 2024
This was referenced Jun 22, 2024
This was referenced Jul 17, 2024
This was referenced Jul 18, 2024
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14622
Summary
When having a sharded collection and having set shardKey on the schema, using buildBulkWriteOperations does not take the shardKey into account.
The documention for shardKey states (https://mongoosejs.com/docs/guide.html#shardKey):
This PR enabled support for the shardKey option when using the buildBulkWriteOperations method.
Examples
Given this schema
and assuming an saved document m, this bulkSave action will correctly include sensorId in the bulkWrite command: