-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: avoid inferring Boolean, Buffer, ObjectId as Date in schema definitions under certain circumstances #14667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finitions under certain circumstances Fix #14630
hasezoey
approved these changes
Jun 16, 2024
This was referenced Jul 8, 2024
This was referenced Jul 9, 2024
This was referenced Aug 5, 2024
This was referenced Aug 7, 2024
This was referenced Aug 15, 2024
This was referenced Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14630
Summary
#14630 pointed out that, under certain circumstances that I'm unable to quantify exactly,
Boolean
,mongoose.Schema.Types.ObjectId
, and several other schema types get inferred as dates. This doesn't happen in tsd, or if Mongoose is symlinked into node_modules, so we can't write tests for this issue with our current testing setup.I tracked the issue down to somehow
typeof NativeDate
catchingBoolean
and other data class types. This PR appears to fix the issue, and doesn't break any existing code that we're currently aware of.Examples