Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(cursor): indicate that cursor.next() can return null #14798

Merged
merged 1 commit into from
Aug 10, 2024
Merged

types(cursor): indicate that cursor.next() can return null #14798

merged 1 commit into from
Aug 10, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14787

Summary

await cursor.next() will be null if there's no more docs

Examples

@vkarpov15 vkarpov15 added this to the 8.5.3 milestone Aug 8, 2024
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Aug 9, 2024
@vkarpov15 vkarpov15 merged commit 4fa87e9 into master Aug 10, 2024
5 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14787 branch August 11, 2024 09:27
@saileshbro saileshbro mentioned this pull request Sep 3, 2024
Closed
@unguest unguest mentioned this pull request Sep 3, 2024
Open
@zntb zntb mentioned this pull request Sep 4, 2024
Merged
@saileshbro saileshbro mentioned this pull request Sep 4, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@kingchappers kingchappers mentioned this pull request Sep 4, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 4, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 4, 2024
Open
@JhairDeveloper JhairDeveloper mentioned this pull request Sep 4, 2024
Open
@imamanasoft imamanasoft mentioned this pull request Sep 4, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 4, 2024
Open
@ThisukaM ThisukaM mentioned this pull request Sep 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 4, 2024
Closed
@Knirag Knirag mentioned this pull request Sep 4, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 19, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 19, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 19, 2024
Open
This was referenced Sep 19, 2024
Open
Open
Open
@it21222672 it21222672 mentioned this pull request Sep 19, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 19, 2024
Open
@quangle36 quangle36 mentioned this pull request Sep 20, 2024
Open
@k2xl k2xl mentioned this pull request Sep 20, 2024
Closed
@pradumchintamani pradumchintamani mentioned this pull request Sep 20, 2024
Open
@k2xl k2xl mentioned this pull request Sep 21, 2024
Closed
@pradumchintamani pradumchintamani mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 21, 2024
Open
Open
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 22, 2024
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 22, 2024
Open
@Thareendra2000 Thareendra2000 mentioned this pull request Sep 23, 2024
Open
@Sandani2000 Sandani2000 mentioned this pull request Sep 23, 2024
Open
@k2xl k2xl mentioned this pull request Sep 23, 2024
Closed
@pradumchintamani pradumchintamani mentioned this pull request Sep 23, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 23, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.5.3
Development

Successfully merging this pull request may close these issues.

Cursor.next can return null, but TypeScript says it can't
3 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez