Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: make HydratedSingleSubdocument and HydratedArraySubdocument merge types instead of using & #14800

Merged
merged 1 commit into from
Aug 13, 2024
Merged

types: make HydratedSingleSubdocument and HydratedArraySubdocument merge types instead of using & #14800

merged 1 commit into from
Aug 13, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14793

Summary

As #14793 points out, HydratedSingleSubdocument and HydratedArraySubdocument need to use MergeTypes, otherwise we end up with hard to diagnose compiler errors stemming back to having RawType & HydratedType.

Examples

@vkarpov15 vkarpov15 mentioned this pull request Aug 11, 2024
Closed
2 tasks
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Aug 13, 2024
@vkarpov15 vkarpov15 added this to the 8.5.3 milestone Aug 13, 2024
@vkarpov15 vkarpov15 merged commit c3bd03e into master Aug 13, 2024
5 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14793 branch August 13, 2024 19:47
@saileshbro saileshbro mentioned this pull request Sep 3, 2024
Open
@unguest unguest mentioned this pull request Sep 3, 2024
Open
@zntb zntb mentioned this pull request Sep 4, 2024
Merged
@saileshbro saileshbro mentioned this pull request Sep 4, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@kingchappers kingchappers mentioned this pull request Sep 4, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 4, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 4, 2024
Open
@JhairDeveloper JhairDeveloper mentioned this pull request Sep 4, 2024
Open
@imamanasoft imamanasoft mentioned this pull request Sep 4, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 4, 2024
Open
@ThisukaM ThisukaM mentioned this pull request Sep 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 4, 2024
Closed
@Knirag Knirag mentioned this pull request Sep 4, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 15, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 15, 2024
Open
@Krithiga-Balakrishnan Krithiga-Balakrishnan mentioned this pull request Sep 16, 2024
Open
@Gehansat Gehansat mentioned this pull request Sep 16, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 16, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 16, 2024
Open
@nimren9920 nimren9920 mentioned this pull request Sep 17, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 17, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 17, 2024
Open
@diviyanjanakamesh diviyanjanakamesh mentioned this pull request Sep 18, 2024
Open
@quangle36 quangle36 mentioned this pull request Sep 18, 2024
Open
@tmunzer tmunzer mentioned this pull request Sep 18, 2024
Open
@k2xl k2xl mentioned this pull request Sep 18, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 18, 2024
Open
@alin484 alin484 mentioned this pull request Sep 18, 2024
Open
@anandanshul anandanshul mentioned this pull request Sep 19, 2024
Open
@diviyanjanakamesh diviyanjanakamesh mentioned this pull request Sep 19, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 19, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 19, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Sep 19, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 19, 2024
Open
This was referenced Sep 19, 2024
Open
Open
Open
@it21222672 it21222672 mentioned this pull request Sep 19, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 19, 2024
Open
@quangle36 quangle36 mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.5.3
Development

Successfully merging this pull request may close these issues.

Intersection type error in embedded schema when iterating through an embedded array
2 participants
@vkarpov15 @hasezoey