Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error): add version number to VersionError (4.x) #6852

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

freewil
Copy link
Contributor

@freewil freewil commented Aug 13, 2018

backport to 4.x of dd2483d

Summary

Backports more informative VersionError that includes version to 4.x branch

Test plan

@freewil freewil changed the title feat(error): add version number to VersionError feat(error): add version number to VersionError (4.x) Aug 13, 2018
@Fonger
Copy link
Contributor

Fonger commented Aug 14, 2018

travis-ci fails due to some flaky tests in 4.x so I make a pull request #6853 for this

@vkarpov15 vkarpov15 added this to the 4.13.15 milestone Aug 14, 2018
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 0e0dba0 into Automattic:4.x Aug 14, 2018
@freewil
Copy link
Contributor Author

freewil commented Aug 14, 2018

thanks @Fonger :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants