New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Document.prototype.validateSync returns ValidationError #7499

Merged

vkarpov15 merged 1 commit into Automattic:master from JulioJu:doc-validateSync

Feb 8, 2019

Contributor

JulioJu commented Feb 8, 2019 •

edited

Loading

Sources:
1.

mongoose/lib/document.js

Line 2031 in bee1e1b

_this.invalidate(path, err, undefined, true);

2.

mongoose/lib/document.js

Line 2101 in bee1e1b

if (this.$__.validationError === err) {

3.

mongoose/lib/document.js

Line 2035 in bee1e1b

const err = _this.$__.validationError;

Summary
Document.prototype.validateSync send ValidationError (it inherits of MongooseError).

If your are ok with that thanks sources above, I will make a PR to correct @types/mongoose accordingly


          Documentation: Document.prototype.validateSync returns ValidationError

971e98b

Sources:
    1. https://github.com/Automattic/mongoose/blob/bee1e1b4669185579168d691c214d17077b8bd6e/lib/document.js#L2031
    2. https://github.com/Automattic/mongoose/blob/bee1e1b4669185579168d691c214d17077b8bd6e/lib/document.js#L2101
    3. https://github.com/Automattic/mongoose/blob/bee1e1b4669185579168d691c214d17077b8bd6e/lib/document.js#L2035

vkarpov15 approved these changes

View reviewed changes

Collaborator

vkarpov15 left a comment

Thanks!

vkarpov15 added this to the 5.4.11 milestone

vkarpov15 merged commit c3502ce into Automattic:master

JulioJu pushed a commit to JulioJu/DefinitelyTyped that referenced this pull request


          @types/mongoose : validateSync returns ValidationError

3722ab1

source: Automattic/mongoose#7499 (comment)

JulioJu mentioned this pull request

@types/mongoose : validateSync returns ValidationError DefinitelyTyped/DefinitelyTyped#32923

Merged

9 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet