Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#8093] Fixes performance of update validator, and flatten function logic #8192

Merged
merged 2 commits into from
Sep 26, 2019
Merged

[#8093] Fixes performance of update validator, and flatten function logic #8192

merged 2 commits into from
Sep 26, 2019

Commits on Sep 23, 2019

  1. [Automattic#8093] Fixes performance of update validator, and flatten … 

    …function logic

Before this commit the `flatten(..)` function failed to deliver what it
promised. Namely, it entered into Mixed paths of objects.

Update validator, on its side, did not pass the casted doc schema into
`flatten(..)`. If the casted doc contained a large Mixed field, all its
paths were added into the list of updated paths. They were lated ignored
by now removed check for schemaPath type, but performance was already
hurt.

This commit makes sure that inner sub-paths of Mixed paths are not
included into the array of paths at all, thus no further checks of that
are necessary, and the performance is restored.

Fixes Automattic#8093
    @birdofpreyru
    birdofpreyru committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    1a01713 View commit details
    Browse the repository at this point in the history

  2. Fixes the previous commit

    @birdofpreyru
    birdofpreyru committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    c76e062 View commit details
    Browse the repository at this point in the history