fix: limit multisizes of sticky ads (#109)

Automattic · Feb 24, 2021 · 481fccc · 481fccc
1 parent ffb661b
commit 481fccc
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/includes/class-newspack-ads-model.php b/includes/class-newspack-ads-model.php
@@ -383,15 +383,19 @@ public static function amp_code_for_ad_unit( $ad_unit ) {
 		$multisizes           = [];
 		foreach ( $sizes as $size ) {
 			$multisize = $size[0] . 'x' . $size[1];
-			if ( $multisize !== $ad_size_as_multisize ) {
+			if (
+				( $multisize !== $ad_size_as_multisize ) &&
+				( ! self::is_sticky( $ad_unit ) || ( self::is_sticky( $ad_unit ) && $size[0] < 600 ) )
+			) {
 				$multisizes[] = $multisize;
 			}
 		}
 		$multisize_attribute = '';
 		if ( count( $multisizes ) ) {
-			$multisize_attribute = sprintf( 
-				'data-multi-size=\'%s\' data-multi-size-validation=\'false\'', 
-				implode( ',', $multisizes ) 
+			$multisize_attribute = sprintf(
+				'data-multi-size=\'%s\' data-multi-size-validation=\'false\'%s',
+				implode( ',', $multisizes ),
+				self::is_sticky( $ad_unit ) ? ' data-override-width=\'600\'' : ''
 			);
 		}