Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Prebid.js #314

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Feb 18, 2022

Version 6.12.0 of Prebid.js released prebid/Prebid.js#7969, so we no longer need to maintain our own version of the babel plugin used for building Prebid.js.

This PR removes the pbjsGlobals plugin and restores the use of the native babel config.

How to test

  1. Run npm ci && npm run build
  2. Confirm the build succeeds
  3. Confirm Prebid.js is working in debug mode (auction logs in console)

@miguelpeixe miguelpeixe requested a review from a team as a code owner February 18, 2022 18:36
@miguelpeixe miguelpeixe self-assigned this Feb 18, 2022
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@miguelpeixe miguelpeixe merged commit bf21b5e into master Feb 18, 2022
@miguelpeixe miguelpeixe deleted the chore/restore-prebid-build-config branch February 19, 2022 04:18
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.28.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants