fix: attribute types for custom author fields (#1365)

Automattic · Feb 15, 2023 · 483e49c · 483e49c
1 parent 46b4515
commit 483e49c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/src/blocks/author-list/block.json b/src/blocks/author-list/block.json
@@ -28,7 +28,12 @@
 		},
 		"authorRoles": {
 			"type": "array",
-			"default": [ "Administrator", "Editor", "Author", "Contributor" ]
+			"default": [
+				"Administrator",
+				"Editor",
+				"Author",
+				"Contributor"
+			]
 		},
 		"authorType": {
 			"type": "string",

diff --git a/src/blocks/author-list/view.php b/src/blocks/author-list/view.php
@@ -18,7 +18,7 @@ function newspack_blocks_register_author_list() {
 		$author_custom_fields = \Newspack\Authors_Custom_Fields::get_custom_fields();
 		foreach ( $author_custom_fields as $field ) {
 			$block_json['attributes'][ 'show' . $field['name'] ] = [
-				'type'    => 'string',
+				'type'    => 'boolean',
 				'default' => true,
 			];
 		}

diff --git a/src/blocks/author-profile/view.php b/src/blocks/author-profile/view.php
@@ -18,7 +18,7 @@ function newspack_blocks_register_author_profile() {
 		$author_custom_fields = \Newspack\Authors_Custom_Fields::get_custom_fields();
 		foreach ( $author_custom_fields as $field ) {
 			$block_json['attributes'][ 'show' . $field['name'] ] = [
-				'type'    => 'string',
+				'type'    => 'boolean',
 				'default' => true,
 			];
 		}

diff --git a/src/blocks/shared/author.js b/src/blocks/shared/author.js
@@ -32,13 +32,13 @@ export const AuthorDisplaySettings = ( { attributes, setAttributes } ) => {
 		<>
 			<p>{ __( 'Display the following fields:', 'newspack-blocks' ) }</p>
 			{ fields.map( field => {
-				const attrbuteName = `show${ field.name }`;
+				const attributeName = `show${ field.name }`;
 				return (
 					<ToggleControl
 						key={ field.name }
 						label={ field.label }
-						checked={ Boolean( attributes[ attrbuteName ] ) }
-						onChange={ () => setAttributes( { [ attrbuteName ]: ! attributes[ attrbuteName ] } ) }
+						checked={ Boolean( attributes[ attributeName ] ) }
+						onChange={ () => setAttributes( { [ attributeName ]: ! attributes[ attributeName ] } ) }
 					/>
 				);
 			} ) }