feat: real author links for avatar and author name

Automattic · May 4, 2020 · 4dedb72 · 4dedb72
1 parent e2f72f5
commit 4dedb72
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/class-newspack-blocks-api.php b/class-newspack-blocks-api.php
@@ -164,13 +164,19 @@ public static function newspack_blocks_get_author_info( $object ) {
 				} else {
 					$author_avatar = coauthors_get_avatar( $author, 48 );
 				}
+				$author_link = null;
+				if ( function_exists( 'coauthors_posts_links' ) ) {
+					$author_link = get_author_posts_url( $author->ID, $author->user_nicename );
+				}
 				$author_data[] = array(
 					/* Get the author name */
 					'display_name' => esc_html( $author->display_name ),
 					/* Get the author avatar */
 					'avatar'       => wp_kses_post( $author_avatar ),
 					/* Get the author ID */
 					'id'           => $author->ID,
+					/* Get the author Link */
+					'author_link'  => $author_link,
 				);
 			}
 		else :
@@ -181,6 +187,8 @@ public static function newspack_blocks_get_author_info( $object ) {
 				'avatar'       => get_avatar( $object['author'], 48 ),
 				/* Get the author ID */
 				'id'           => $object['author'],
+				/* Get the author Link */
+				'author_link'  => get_author_posts_url( $object['author'] ),
 			);
 		endif;
 

diff --git a/src/shared/js/utils.js b/src/shared/js/utils.js
@@ -7,7 +7,7 @@ import { RawHTML } from '@wordpress/element';
 export const formatAvatars = authorInfo =>
 	authorInfo.map( author => (
 		<span className="avatar author-avatar" key={ author.id }>
-			<a className="url fn n" href="#">
+			<a className="url fn n" href={ author.author_link }>
 				<RawHTML>{ author.avatar }</RawHTML>
 			</a>
 		</span>
@@ -20,7 +20,7 @@ export const formatByline = authorInfo => (
 			return [
 				...accumulator,
 				<span className="author vcard" key={ author.id }>
-					<a className="url fn n" href="#">
+					<a className="url fn n" href={ author.author_link }>
 						{ author.display_name }
 					</a>
 				</span>,